]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:gensec_krb5: make use of talloc_zero() in gensec_krb5_start()
authorStefan Metzmacher <metze@samba.org>
Wed, 13 Nov 2019 10:07:31 +0000 (11:07 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 10 Feb 2020 16:32:37 +0000 (16:32 +0000)
This is simpler and safter in case the structure gets new elements.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/auth/gensec/gensec_krb5.c

index ccb9a4f110e623a2f3a0d546c3bdad5cfd7d18dd..4b89dfc0b44c7668af7950b62d190c067b0078ea 100644 (file)
@@ -107,17 +107,12 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       gensec_krb5_state = talloc(gensec_security, struct gensec_krb5_state);
+       gensec_krb5_state = talloc_zero(gensec_security, struct gensec_krb5_state);
        if (!gensec_krb5_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
        gensec_security->private_data = gensec_krb5_state;
-       gensec_krb5_state->smb_krb5_context = NULL;
-       gensec_krb5_state->auth_context = NULL;
-       gensec_krb5_state->ticket = NULL;
-       ZERO_STRUCT(gensec_krb5_state->enc_ticket);
-       gensec_krb5_state->keyblock = NULL;
        gensec_krb5_state->gssapi = gssapi;
 
        talloc_set_destructor(gensec_krb5_state, gensec_krb5_destroy);