habanalabs: remove node from list before freeing the node

[ Upstream commit f5eb7bf0c487a212ebda3c1b048fc3ccabacc147 ]

fix the following smatch warnings:

goya_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

gaudi_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index a03f13aa47f89592e25e3c4f7edc3329d088f020..0c6092ebbc04c52f8c0289721884e75e6ae842ef 100644 (file)
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -4901,6 +4901,7 @@ already_pinned:
        return 0;
 
 unpin_memory:
+       list_del(&userptr->job_node);
        hl_unpin_host_memory(hdev, userptr);
 free_userptr:
        kfree(userptr);

diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index ed566c52ccaa09313f17ab72b2070d42ca11bc18..45c9065c4b92270e776fd781644093500203b5f9 100644 (file)
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -3249,6 +3249,7 @@ already_pinned:
        return 0;
 
 unpin_memory:
+       list_del(&userptr->job_node);
        hl_unpin_host_memory(hdev, userptr);
 free_userptr:
        kfree(userptr);