Chore: refactor permission checks to use queryset.exists()

diff --git a/src/documents/permissions.py b/src/documents/permissions.py
index cf6a9aa35c09198d885aed26792354e2aea1fb4d..802cb8798e58085c7f40ea4a037ee51a942d5104 100644 (file)
--- a/src/documents/permissions.py
+++ b/src/documents/permissions.py
@@ -85,12 +85,12 @@ def set_permissions_for_object(permissions: list[str], object, *, merge: bool =
                 if not merge
                 else User.objects.none()
             )
-            if len(users_to_add) > 0 and len(users_to_remove) > 0:
+            if users_to_add.exists() and users_to_remove.exists():
                 users_to_remove = users_to_remove.exclude(id__in=users_to_add)
-            if len(users_to_remove) > 0:
+            if users_to_remove.exists():
                 for user in users_to_remove:
                     remove_perm(permission, user, object)
-            if len(users_to_add) > 0:
+            if users_to_add.exists():
                 for user in users_to_add:
                     assign_perm(permission, user, object)
                     if action == "change":
@@ -111,12 +111,12 @@ def set_permissions_for_object(permissions: list[str], object, *, merge: bool =
                 if not merge
                 else Group.objects.none()
             )
-            if len(groups_to_add) > 0 and len(groups_to_remove) > 0:
+            if groups_to_add.exists() and groups_to_remove.exists():
                 groups_to_remove = groups_to_remove.exclude(id__in=groups_to_add)
-            if len(groups_to_remove) > 0:
+            if groups_to_remove.exists():
                 for group in groups_to_remove:
                     remove_perm(permission, group, object)
-            if len(groups_to_add) > 0:
+            if groups_to_add.exists():
                 for group in groups_to_add:
                     assign_perm(permission, group, object)
                     if action == "change":