Bug 106918: the "movers" param was not being interpreted correctly by move.pl or...

r= myk, a= justdave

diff --git a/Bug.pm b/Bug.pm
index 35f8402ef844fcb51a549e7f895e181815af687a..dd91d6f3f211652a46736281e492a39fe8b0676e 100755 (executable)
--- a/Bug.pm
+++ b/Bug.pm
@@ -362,6 +362,8 @@ sub user {
     $self->{'user'} = {};
 
     my $movers = Param("movers");
+    $movers =~ s/\s?,\s?/|/g;
+    $movers =~ s/@/\@/g;
     $self->{'user'}->{'canmove'} = Param("move-enabled") 
       && (defined $::COOKIE{"Bugzilla_login"}) 
         && ($::COOKIE{"Bugzilla_login"} =~ /$movers/);

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 35f8402ef844fcb51a549e7f895e181815af687a..dd91d6f3f211652a46736281e492a39fe8b0676e 100755 (executable)
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -362,6 +362,8 @@ sub user {
     $self->{'user'} = {};
 
     my $movers = Param("movers");
+    $movers =~ s/\s?,\s?/|/g;
+    $movers =~ s/@/\@/g;
     $self->{'user'}->{'canmove'} = Param("move-enabled") 
       && (defined $::COOKIE{"Bugzilla_login"}) 
         && ($::COOKIE{"Bugzilla_login"} =~ /$movers/);

diff --git a/move.pl b/move.pl
index 4807bf6d97f1e5e1859b8083a0f9c4eafcc7eb34..7d3d845530c86706bd43a4f6fbffb5d9396b14b9 100755 (executable)
--- a/move.pl
+++ b/move.pl
@@ -86,7 +86,7 @@ if ( !defined $::FORM{'buglist'} ) {
 
 my $exporter = $::COOKIE{"Bugzilla_login"};
 my $movers = Param("movers");
-$movers =~ s/\w?,\w?/|/g;
+$movers =~ s/\s?,\s?/|/g;
 $movers =~ s/@/\@/g;
 unless ($exporter =~ /($movers)/) {
   print "Content-type: text/html\n\n";
@@ -149,7 +149,7 @@ $from =~ s/@/\@/;
 $msg .= "From: Bugzilla <" . $from . ">\n";
 $msg .= "Subject: Moving bug(s) $buglist\n\n";
 
-$template->process("bug/show.xml.tmpl", { bugs => \@bugs }, \$msg)
+$template->process("bug/show.xml.tmpl", { user => { login => $exporter }, bugs => \@bugs }, \$msg)
   || ThrowTemplateError($template->error());
 
 $msg .= "\n";