tests: Improve the error message for bad format chars

Print the faulty character for easier finding it.

I did not find out how to split the format string into two lines such
that self.fail would properly print the whole thing in its exception,
so we have a long line here.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/python/samba/tests/source_chars.py b/python/samba/tests/source_chars.py
index 46130888cbc078d659808d189cf4fdac3d79f005..dea7fcc98192161abf38618c823679efb1000779 100755 (executable)
--- a/python/samba/tests/source_chars.py
+++ b/python/samba/tests/source_chars.py
@@ -241,7 +241,7 @@ class CharacterTests(TestCase):
             dirs = set()
             for c in set(s):
                 if is_bad_char(c):
-                    self.fail(f"{name} has potentially bad format characters!")
+                    self.fail(f"{name} has potentially bad format character {ord(c[0])}!")
                 dirs.add(u.bidirectional(c))
 
             if 'L' in dirs and 'R' in dirs: