]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
object: Avoid returning garbage in nftnl_obj_do_parse()
authorPhil Sutter <phil@nwl.cc>
Thu, 14 Dec 2017 19:40:22 +0000 (20:40 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 15 Dec 2017 15:22:46 +0000 (16:22 +0100)
It may happen that 'perr' variable does not get initialized, so making
parameter 'err' point to it in any case is error-prone. Avoid this by
initializing 'perr' upon declaration.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/object.c

index 9a4ee712a2a95e8ab5a59131136ded1aa8dd8f1e..da3423bf3381a17516826f15add5ca82d4cbc972 100644 (file)
@@ -358,7 +358,7 @@ static int nftnl_obj_do_parse(struct nftnl_obj *obj, enum nftnl_parse_type type,
                              const void *data, struct nftnl_parse_err *err,
                              enum nftnl_parse_input input)
 {
-       struct nftnl_parse_err perr;
+       struct nftnl_parse_err perr = {};
        int ret;
 
        switch (type) {