]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netdevsim: don't leak devlink resources
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 25 Jul 2018 22:39:27 +0000 (15:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:48:04 +0000 (07:48 +0200)
[ Upstream commit c259b4fb33ee6e7667bf1d34bf0803b7c5fdbdce ]

Devlink resources registered with devlink_resource_register() have
to be unregistered.

Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via devlink")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/netdevsim/devlink.c

index bef7db5d129a55c31b6d0f2a5094c7b61b61b1d5..82f0e2663e1a141ca47c0d609a06667b6d9e13ff 100644 (file)
@@ -206,6 +206,7 @@ void nsim_devlink_teardown(struct netdevsim *ns)
                struct net *net = nsim_to_net(ns);
                bool *reg_devlink = net_generic(net, nsim_devlink_id);
 
+               devlink_resources_unregister(ns->devlink, NULL);
                devlink_unregister(ns->devlink);
                devlink_free(ns->devlink);
                ns->devlink = NULL;