BUG/MEDIUM: checks: a down server going to maint remains definitely stucked on down...

The new admin state was not correctly commited in this case.
Checks were fully disabled but the server was not marked in MAINT state.
It results with a server definitely stucked on the DOWN state.

This patch should be backported on haproxy 1.8

diff --git a/src/server.c b/src/server.c
index 9b4d66f941024d857549a71496ca7e1ebcec634e..23e4cc98e0853706e826455c969ab400494c3413 100644 (file)
--- a/src/server.c
+++ b/src/server.c
@@ -4623,6 +4623,9 @@ void srv_update_status(struct server *s)
                                free_trash_chunk(tmptrash);
                                tmptrash = NULL;
                        }
+                       /* commit new admin status */
+
+                       s->cur_admin = s->next_admin;
                }
                else {  /* server was still running */
                        check->health = 0; /* failure */