]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mt76: mt7996: Fix null-ptr-deref in mt7996_mmio_wed_init()
authorHenry Martin <bsdhenrymartin@gmail.com>
Mon, 7 Apr 2025 03:23:49 +0000 (11:23 +0800)
committerFelix Fietkau <nbd@nbd.name>
Thu, 22 May 2025 10:57:36 +0000 (12:57 +0200)
devm_ioremap() returns NULL on error. Currently, mt7996_mmio_wed_init()
does not check for this case, which results in a NULL pointer
dereference.

Prevent null pointer dereference in mt7996_mmio_wed_init()

Fixes: 83eafc9251d6 ("wifi: mt76: mt7996: add wed tx support")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Link: https://patch.msgid.link/20250407032349.83360-1-bsdhenrymartin@gmail.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mmio.c

index 51dd9a5f83cca6417cfcb75634c469a800fb593a..30b40f4a91be81d429d11f15036167396756d2dc 100644 (file)
@@ -477,6 +477,9 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
        wed->wlan.base = devm_ioremap(dev->mt76.dev,
                                      pci_resource_start(pci_dev, 0),
                                      pci_resource_len(pci_dev, 0));
+       if (!wed->wlan.base)
+               return -ENOMEM;
+
        wed->wlan.phy_base = pci_resource_start(pci_dev, 0);
 
        if (hif2) {