Update 3 files

- /src/feature/dirauth/process_descs.c
- /src/test/test_process_descs.c
- /changes/ticket40760

diff --git a/changes/ticket40760 b/changes/ticket40760
new file mode 100644 (file)
index 0000000..b5e3df7
--- /dev/null
+++ b/changes/ticket40760
@@ -0,0 +1,3 @@
+  o Minor feature (authority):
+    - Reject 0.4.5.x series at the authority level. Closes ticket 40760.
+

diff --git a/src/feature/dirauth/process_descs.c b/src/feature/dirauth/process_descs.c
index 3cdace452f2079870aac532d6ca4052b55173756..7fd930e246e0f8da33b57f623554d192344aba56 100644 (file)
--- a/src/feature/dirauth/process_descs.c
+++ b/src/feature/dirauth/process_descs.c
@@ -404,17 +404,8 @@ dirserv_rejects_tor_version(const char *platform,
   static const char please_upgrade_string[] =
     "Tor version is insecure or unsupported. Please upgrade!";
 
-  /* Anything before 0.4.5.6 is unsupported. Reject them. */
-  if (!tor_version_as_new_as(platform,"0.4.5.6")) {
-    if (msg) {
-      *msg = please_upgrade_string;
-    }
-    return true;
-  }
-
-  /* Reject 0.4.6.x series. */
-  if (tor_version_as_new_as(platform, "0.4.6.0") &&
-      !tor_version_as_new_as(platform, "0.4.7.0-alpha-dev")) {
+  /* Anything before 0.4.7.0 is unsupported. Reject them. */
+  if (!tor_version_as_new_as(platform,"0.4.7.0-alpha-dev")) {
     if (msg) {
       *msg = please_upgrade_string;
     }

diff --git a/src/test/test_process_descs.c b/src/test/test_process_descs.c
index abcb6ae2fed25a1eeda8b9ca64bbc627e28ca673..c13e8b58c43d25ca30362ff050f136619dbc6460 100644 (file)
--- a/src/test/test_process_descs.c
+++ b/src/test/test_process_descs.c
@@ -47,17 +47,15 @@ test_process_descs_versions(void *arg)
     { "Tor 0.4.3.0-alpha-dev", true },
     { "Tor 0.4.3.8", true },
     { "Tor 0.4.4.9", true },
-
-    /* The 0.4.5.x series stable is supported. */
     { "Tor 0.4.5.5-rc", true },
-    { "Tor 0.4.5.6", false },
-    { "Tor 0.4.5.15", false },
-
+    { "Tor 0.4.5.6", true },
+    { "Tor 0.4.5.15", true },
     { "Tor 0.4.6.0-alpha-dev", true },
     { "Tor 0.4.6.1-alpha", true },
     { "Tor 0.4.6.5", true },
     { "Tor 0.4.6.50", true }, /* Non existing one in the 0.4.6 series */
 
+    /* The 0.4.7.x series is supported. */
     { "Tor 0.4.7.0-alpha-dev", false },
     { "Tor 0.4.7.3-alpha", false },
     { "Tor 0.4.7.12", false },