]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu: clean up the userq unmap error handler
authorPrike Liang <Prike.Liang@amd.com>
Mon, 27 Apr 2026 12:06:57 +0000 (20:06 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Apr 2026 19:51:18 +0000 (15:51 -0400)
amdgpu_userq_unmap_helper() already handles the unmap error case.

Signed-off-by: Prike Liang <Prike.Liang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 66cb6579990b633ccc7300c27011d837b9a58da0)

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

index d9b9c03267c0b0cea1e18d2920b8fe9153da55d3..de140a8ed1354aa93979182b57f66f442642ebc5 100644 (file)
@@ -656,12 +656,6 @@ amdgpu_userq_destroy(struct amdgpu_userq_mgr *uq_mgr, struct amdgpu_usermode_que
 #endif
        amdgpu_userq_detect_and_reset_queues(uq_mgr);
        r = amdgpu_userq_unmap_helper(queue);
-       /*TODO: It requires a reset for userq hw unmap error*/
-       if (r) {
-               drm_warn(adev_to_drm(uq_mgr->adev), "trying to destroy a HW mapping userq\n");
-               queue->state = AMDGPU_USERQ_STATE_HUNG;
-       }
-
        atomic_dec(&uq_mgr->userq_count[queue->queue_type]);
        amdgpu_userq_cleanup(queue);
        mutex_unlock(&uq_mgr->userq_mutex);