]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
bootstd: android: Add missing free in android_read_bootflow
authorFrancois Berder <fberder@outlook.fr>
Wed, 14 Jan 2026 09:14:55 +0000 (10:14 +0100)
committerMattijs Korpershoek <mkorpershoek@kernel.org>
Thu, 15 Jan 2026 08:26:22 +0000 (09:26 +0100)
If strdup call fails, one needs to free priv variable.

Signed-off-by: Francois Berder <fberder@outlook.fr>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
Link: https://lore.kernel.org/r/BESP194MB28052734FD0361EA602F6360DA8FA@BESP194MB2805.EURP194.PROD.OUTLOOK.COM
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
boot/bootmeth_android.c

index 1374551dbeb5e27703697772bc6fd56b44a609a1..1d70e8d5c058eeedaba016af1ddda759638200bd 100644 (file)
@@ -252,8 +252,10 @@ static int android_read_bootflow(struct udevice *dev, struct bootflow *bflow)
                priv->boot_mode = ANDROID_BOOT_MODE_NORMAL;
                bflow->os_name = strdup("Android");
        }
-       if (!bflow->os_name)
+       if (!bflow->os_name) {
+               free(priv);
                return log_msg_ret("os", -ENOMEM);
+       }
 
        if (priv->boot_mode == ANDROID_BOOT_MODE_BOOTLOADER) {
                /* Clear BCB */