login: duplicate --shell argument to avoid nulling through explicit_bzero()

Addresses: #3855
Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>

diff --git a/login-utils/login.c b/login-utils/login.c
index 3cd1d528bed6ce93d017a9f5697cfa94b4dd20e1..604d63c235b61aa5dc587296c6decfa382fb3a1f 100644 (file)
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -1384,7 +1384,7 @@ static void initialize(int argc, char **argv, struct login_context *cxt)
                        break;
 
                case 's':
-                       cxt->shell_arg = optarg;
+                       cxt->shell_arg = xstrdup(optarg);
                        break;
 
                case 'V':