media: atmel-isi: use devm_kmemdup_array()

Convert to use devm_kmemdup_array() and while at it, make the size robust
against type changes.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index 0d1c3934752972190d8a1ded9a04b2be2b768c36..a05a744cbb7569abff60ccf1a0825a9c3c52ed8a 100644 (file)
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -1072,16 +1072,12 @@ static int isi_formats_init(struct atmel_isi *isi)
                return -ENXIO;
 
        isi->num_user_formats = num_fmts;
-       isi->user_formats = devm_kcalloc(isi->dev,
-                                        num_fmts, sizeof(struct isi_format *),
-                                        GFP_KERNEL);
+       isi->user_formats = devm_kmemdup_array(isi->dev, isi_fmts, num_fmts,
+                                              sizeof(*isi_fmts), GFP_KERNEL);
        if (!isi->user_formats)
                return -ENOMEM;
 
-       memcpy(isi->user_formats, isi_fmts,
-              num_fmts * sizeof(struct isi_format *));
        isi->current_fmt = isi->user_formats[0];
-
        return 0;
 }