net: phy: sfp: probe for RollBall I2C-to-MDIO bridge in mdio-i2c

The "OEM"/"SFP-10G-T" quirk entry in sfp_fixup_rollball_cc()
unconditionally forces MDIO_I2C_ROLLBALL for all modules matching that
vendor/part-number combination.  This works for modules that genuinely
implement a RollBall I2C-to-MDIO bridge, but silently breaks modules
that share the same EEPROM strings without having such a bridge.

The Realtek RTL8261BE-CG is one such module: a pure copper 10G SFP+
media converter with no I2C-to-MDIO bridge.  Its EEPROM reports
vendor="OEM", part="SFP-10G-T-I", and -- critically -- Vendor OUI
00:00:00, making OUI-based differentiation impossible.  With
MDIO_I2C_ROLLBALL forced, the module silently ACKs the unlock password
write, the MDIO bus is created, but no PHY responds; the SFP state
machine cycles through the RollBall PHY-probe retry window before
reporting no PHY.

Move the probe into i2c_mii_init_rollball() in mdio-i2c.c, where the
RollBall protocol constants are already defined.  After sending the
unlock password, issue a CMD_READ and poll for CMD_DONE up to 200 ms
(10 x 20 ms, matching the existing rollball poll tolerance).  A genuine
RollBall bridge asserts CMD_DONE within that window; modules without a
bridge never do, so i2c_mii_init_rollball() returns -ENODEV.
mdio_i2c_alloc() propagates -ENODEV to the caller to signal that no
bridge is present and PHY probing should be skipped.
sfp_sm_add_mdio_bus() catches -ENODEV and transitions
sfp->mdio_protocol to MDIO_I2C_NONE so the rest of the state machine
skips PHY probing for this module.

Any I2C-level error (NACK, timeout) during the probe is also treated as
-ENODEV: if the module does not respond at I2C address 0x51 at all,
there is certainly no RollBall bridge there, and SFP initialization
should not abort.

The probe writes are safe with respect to SFP EEPROM integrity: only
modules explicitly listed in the quirk table enter this path, and the
RollBall password unlock write to 0x51 was already issued by
i2c_mii_init_rollball() before the probe for all such modules.  Any
module without a device at 0x51 NACKs the transfer and is treated as
-ENODEV.

Add "OEM"/"SFP-10G-T-I" to the quirk table so RTL8261BE modules enter
the probe path; genuine RollBall modules continue to work as before.

Signed-off-by: Petr Wozniak <petr.wozniak@gmail.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260527053909.2118-1-petr.wozniak@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/mdio/mdio-i2c.c b/drivers/net/mdio/mdio-i2c.c
index ed20352a589a3dd20255561280e208aa11996a83..b88f63234b4e6a5bdc40c19f37f94c7bc77d6d5f 100644 (file)
--- a/drivers/net/mdio/mdio-i2c.c
+++ b/drivers/net/mdio/mdio-i2c.c
@@ -419,6 +419,50 @@ static int i2c_mii_write_rollball(struct mii_bus *bus, int phy_id, int devad,
        return 0;
 }
 
+static int i2c_mii_probe_rollball(struct i2c_adapter *i2c)
+{
+       u8 data_buf[] = { ROLLBALL_DATA_ADDR, 0x01, 0x00, 0x00 };
+       u8 cmd_buf[]  = { ROLLBALL_CMD_ADDR, ROLLBALL_CMD_READ };
+       u8 cmd_addr   = ROLLBALL_CMD_ADDR;
+       struct i2c_msg msgs[2];
+       u8 result;
+       int ret;
+       int i;
+
+       msgs[0].addr  = ROLLBALL_PHY_I2C_ADDR;
+       msgs[0].flags = 0;
+       msgs[0].len   = sizeof(data_buf);
+       msgs[0].buf   = data_buf;
+       msgs[1].addr  = ROLLBALL_PHY_I2C_ADDR;
+       msgs[1].flags = 0;
+       msgs[1].len   = sizeof(cmd_buf);
+       msgs[1].buf   = cmd_buf;
+
+       ret = i2c_transfer_rollball(i2c, msgs, ARRAY_SIZE(msgs));
+       if (ret < 0)
+               return -ENODEV;
+
+       msgs[0].addr  = ROLLBALL_PHY_I2C_ADDR;
+       msgs[0].flags = 0;
+       msgs[0].len   = 1;
+       msgs[0].buf   = &cmd_addr;
+       msgs[1].addr  = ROLLBALL_PHY_I2C_ADDR;
+       msgs[1].flags = I2C_M_RD;
+       msgs[1].len   = 1;
+       msgs[1].buf   = &result;
+
+       for (i = 0; i < 10; i++) {
+               msleep(20);
+               ret = i2c_transfer_rollball(i2c, msgs, ARRAY_SIZE(msgs));
+               if (ret < 0)
+                       return -ENODEV;
+               if (result == ROLLBALL_CMD_DONE)
+                       return 0;
+       }
+
+       return -ENODEV;
+}
+
 static int i2c_mii_init_rollball(struct i2c_adapter *i2c)
 {
        struct i2c_msg msg;
@@ -438,11 +482,11 @@ static int i2c_mii_init_rollball(struct i2c_adapter *i2c)
 
        ret = i2c_transfer(i2c, &msg, 1);
        if (ret < 0)
-               return ret;
-       else if (ret != 1)
+               return -ENODEV;
+       if (ret != 1)
                return -EIO;
-       else
-               return 0;
+
+       return i2c_mii_probe_rollball(i2c);
 }
 
 static bool mdio_i2c_check_functionality(struct i2c_adapter *i2c,
@@ -487,9 +531,10 @@ struct mii_bus *mdio_i2c_alloc(struct device *parent, struct i2c_adapter *i2c,
        case MDIO_I2C_ROLLBALL:
                ret = i2c_mii_init_rollball(i2c);
                if (ret < 0) {
-                       dev_err(parent,
-                               "Cannot initialize RollBall MDIO I2C protocol: %d\n",
-                               ret);
+                       if (ret != -ENODEV)
+                               dev_err(parent,
+                                       "Cannot initialize RollBall MDIO I2C protocol: %d\n",
+                                       ret);
                        mdiobus_free(mii);
                        return ERR_PTR(ret);
                }

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7a865f69a6bda0f7ae9e5e44d364e6cf587fd9df..376c705a909d2eb3f975ad3dc3eb24bd5350887d 100644 (file)
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -579,6 +579,7 @@ static const struct sfp_quirk sfp_quirks[] = {
        // OEM SFP-GE-T is a 1000Base-T module with broken TX_FAULT indicator
        SFP_QUIRK_F("OEM", "SFP-GE-T", sfp_fixup_ignore_tx_fault),
 
+       SFP_QUIRK_F("OEM", "SFP-10G-T-I", sfp_fixup_rollball),
        SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
        SFP_QUIRK_S("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
        SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
@@ -2024,10 +2025,17 @@ static void sfp_sm_fault(struct sfp *sfp, unsigned int next_state, bool warn)
 
 static int sfp_sm_add_mdio_bus(struct sfp *sfp)
 {
-       if (sfp->mdio_protocol != MDIO_I2C_NONE)
-               return sfp_i2c_mdiobus_create(sfp);
+       int ret;
 
-       return 0;
+       if (sfp->mdio_protocol == MDIO_I2C_NONE)
+               return 0;
+
+       ret = sfp_i2c_mdiobus_create(sfp);
+       if (ret == -ENODEV) {
+               sfp->mdio_protocol = MDIO_I2C_NONE;
+               return 0;
+       }
+       return ret;
 }
 
 /* Probe a SFP for a PHY device if the module supports copper - the PHY