]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: always assume QEMU_CAPS_SPICE_UNIX
authorJán Tomko <jtomko@redhat.com>
Tue, 2 Nov 2021 15:17:36 +0000 (16:17 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 4 Nov 2021 13:37:15 +0000 (14:37 +0100)
The presence of this capability depends on QEMU being compiled
with spice that has the SPICE_ADDR_FLAG_UNIX_ONLY constant.
It was added by spice commit 5365caeaae released in spice v0.12.6,
which is older than the spice version on our supported architectures.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_validate.c

index c4384dbe8b8d3846a9636d39a635e1c77d53c12e..397eea5edeaa1c1548476e3948c50d49ee1ef9c4 100644 (file)
@@ -4037,15 +4037,6 @@ qemuValidateDomainDeviceDefSPICEGraphics(const virDomainGraphicsDef *graphics,
     }
 
     switch (glisten->type) {
-    case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET:
-        if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SPICE_UNIX)) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                           _("unix socket for spice graphics are not supported "
-                             "with this QEMU"));
-            return -1;
-        }
-        break;
-
     case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS:
     case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK:
         if (tlsPort > 0 && !cfg->spiceTLS) {
@@ -4056,6 +4047,7 @@ qemuValidateDomainDeviceDefSPICEGraphics(const virDomainGraphicsDef *graphics,
         }
         break;
 
+    case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET:
     case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE:
         break;
     case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: