app-layer-ssl: fix use-after-free (CID 1433623)

Ja3BufferAddValue frees the buffer on error, so there is no point
in doing it twice (use-after-free).

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index c89bd369e9d2460cf39a5b386769bc1871a96b2b..0f290e93d306f5e0d4bdb1a886a75ecc7a40bb08 100644 (file)
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -660,7 +660,6 @@ static inline int TLSDecodeHSHelloCipherSuites(SSLState *ssl_state,
             if (TLSDecodeValueIsGREASE(cipher_suite) != 1) {
                 rc = Ja3BufferAddValue(ja3_cipher_suites, cipher_suite);
                 if (rc != 0) {
-                    Ja3BufferFree(&ja3_cipher_suites);
                     return -1;
                 }
             }