]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: rockchip: i2s-tdm: Omit a variable reassignment in rockchip_i2s_tdm_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 20 Oct 2025 16:11:58 +0000 (18:11 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 21 Oct 2025 14:10:52 +0000 (15:10 +0100)
An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/115fba03-e8ba-4bc1-84d8-7d483c06208c@web.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s_tdm.c

index d9a1fab7f40310cdb2c4b97a5de67dd12d46a16a..770b9bfbb384aeafdb55ac52a0768410e18fb581 100644 (file)
@@ -1337,8 +1337,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev)
 
        ret = i2s_tdm_prepare_enable_mclk(i2s_tdm);
        if (ret) {
-               ret = dev_err_probe(i2s_tdm->dev, ret,
-                                   "Failed to enable one or more mclks\n");
+               dev_err_probe(i2s_tdm->dev, ret, "Failed to enable one or more mclks\n");
                goto err_disable_hclk;
        }