]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: xen: scsiback: Fix potential memory leak in scsiback_remove()
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>
Tue, 23 Dec 2025 06:30:11 +0000 (12:00 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 12 Jan 2026 02:35:49 +0000 (21:35 -0500)
Memory allocated for struct vscsiblk_info in scsiback_probe() is not
freed in scsiback_remove() leading to potential memory leaks on remove,
as well as in the scsiback_probe() error paths. Fix that by freeing it
in scsiback_remove().

Cc: stable@vger.kernel.org
Fixes: d9d660f6e562 ("xen-scsiback: Add Xen PV SCSI backend driver")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://patch.msgid.link/20251223063012.119035-1-nihaal@cse.iitm.ac.in
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/xen/xen-scsiback.c

index 0c51edfd13dcdfbb12c988c63c78cd85ea0b086d..7d5117e5efe0e92f969d3018490eb899a46319c4 100644 (file)
@@ -1262,6 +1262,7 @@ static void scsiback_remove(struct xenbus_device *dev)
        gnttab_page_cache_shrink(&info->free_pages, 0);
 
        dev_set_drvdata(&dev->dev, NULL);
+       kfree(info);
 }
 
 static int scsiback_probe(struct xenbus_device *dev,