- fixed relationship deletion error where parent/child with a single column as PK/FK

on the child would raise a "blank out the primary key" error, if manually deleted
or "delete" cascade without "delete-orphan" was used

diff --git a/CHANGES b/CHANGES
index 7cbf6c85ee9e86773ef773a42f49da31bec8ba27..31802b823ce577237197fb003c1cf3e6683a2468 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -29,6 +29,9 @@
   - contains_eager('foo') automatically implies eagerload('foo')
   - fixed bug where cascade operations incorrectly included deleted collection
   items in the cascade [ticket:445]
+  - fixed relationship deletion error where parent/child with a single column as PK/FK 
+  on the child would raise a "blank out the primary key" error, if manually deleted
+  or "delete" cascade without "delete-orphan" was used
   - fix to deferred so that load operation doesnt mistakenly occur when only
   PK col attributes are set
   - added support for py2.5 "with" statement with SessionTransaction [ticket:468]

diff --git a/lib/sqlalchemy/orm/dependency.py b/lib/sqlalchemy/orm/dependency.py
index 86bb503fddf8bbee26f804bf8b48987b0b88012d..4e4385ef12a21c2b2e1778297842e71616228935 100644 (file)
--- a/lib/sqlalchemy/orm/dependency.py
+++ b/lib/sqlalchemy/orm/dependency.py
@@ -74,7 +74,7 @@ class DependencyProcessor(object):
         instance which will require save/update/delete is properly added to the UOWTransaction."""
         raise NotImplementedError()
 
-    def _synchronize(self, obj, child, associationrow, clearkeys):
+    def _synchronize(self, obj, child, associationrow, clearkeys, uowcommit):
         """called during a flush to synchronize primary key identifier values between a parent/child object, as well as 
         to an associationrow in the case of many-to-many."""
         raise NotImplementedError()
@@ -134,22 +134,22 @@ class OneToManyDP(DependencyProcessor):
                     if childlist is not None:
                         for child in childlist.deleted_items():
                             if child is not None and childlist.hasparent(child) is False:
-                                self._synchronize(obj, child, None, True)
+                                self._synchronize(obj, child, None, True, uowcommit)
                                 self._conditional_post_update(child, uowcommit, [obj])
                         for child in childlist.unchanged_items():
                             if child is not None:
-                                self._synchronize(obj, child, None, True)
+                                self._synchronize(obj, child, None, True, uowcommit)
                                 self._conditional_post_update(child, uowcommit, [obj])
         else:
             for obj in deplist:
                 childlist = self.get_object_dependencies(obj, uowcommit, passive=True)
                 if childlist is not None:
                     for child in childlist.added_items():
-                        self._synchronize(obj, child, None, False)
+                        self._synchronize(obj, child, None, False, uowcommit)
                         self._conditional_post_update(child, uowcommit, [obj])
                     for child in childlist.deleted_items():
                         if not self.cascade.delete_orphan:
-                            self._synchronize(obj, child, None, True)
+                            self._synchronize(obj, child, None, True, uowcommit)
 
     def preprocess_dependencies(self, task, deplist, uowcommit, delete = False):
         #print self.mapper.mapped_table.name + " " + self.key + " " + repr(len(deplist)) + " preprocess_dep isdelete " + repr(delete) + " direction " + repr(self.direction)
@@ -198,10 +198,10 @@ class OneToManyDP(DependencyProcessor):
                             for c in self.mapper.cascade_iterator('delete', child):
                                 uowcommit.register_object(c, isdelete=True)
             
-    def _synchronize(self, obj, child, associationrow, clearkeys):
+    def _synchronize(self, obj, child, associationrow, clearkeys, uowcommit):
         source = obj
         dest = child
-        if dest is None:
+        if dest is None or (not self.post_update and uowcommit.is_deleted(dest)):
             return
         self.syncrules.execute(source, dest, obj, child, clearkeys)
     
@@ -223,7 +223,7 @@ class ManyToOneDP(DependencyProcessor):
                 # post_update means we have to update our row to not reference the child object
                 # before we can DELETE the row
                 for obj in deplist:
-                    self._synchronize(obj, None, None, True)
+                    self._synchronize(obj, None, None, True, uowcommit)
                     childlist = self.get_object_dependencies(obj, uowcommit, passive=self.passive_deletes)
                     if childlist is not None:
                         self._conditional_post_update(obj, uowcommit, childlist.deleted_items() + childlist.unchanged_items() + childlist.added_items())
@@ -232,9 +232,8 @@ class ManyToOneDP(DependencyProcessor):
                 childlist = self.get_object_dependencies(obj, uowcommit, passive=True)
                 if childlist is not None:
                     for child in childlist.added_items():
-                        self._synchronize(obj, child, None, False)
+                        self._synchronize(obj, child, None, False, uowcommit)
                     self._conditional_post_update(obj, uowcommit, childlist.deleted_items() + childlist.unchanged_items() + childlist.added_items())
-                        
     def preprocess_dependencies(self, task, deplist, uowcommit, delete = False):
         #print self.mapper.mapped_table.name + " " + self.key + " " + repr(len(deplist)) + " PRE process_dep isdelete " + repr(delete) + " direction " + repr(self.direction)
         if self.post_update:
@@ -261,10 +260,10 @@ class ManyToOneDP(DependencyProcessor):
                                 for c in self.mapper.cascade_iterator('delete', child):
                                     uowcommit.register_object(c, isdelete=True)
                         
-    def _synchronize(self, obj, child, associationrow, clearkeys):
+    def _synchronize(self, obj, child, associationrow, clearkeys, uowcommit):
         source = child
         dest = obj
-        if dest is None:
+        if dest is None or (not self.post_update and uowcommit.is_deleted(dest)):
             return
         self.syncrules.execute(source, dest, obj, child, clearkeys)
 
@@ -296,7 +295,7 @@ class ManyToManyDP(DependencyProcessor):
                 if childlist is not None:
                     for child in childlist.deleted_items() + childlist.unchanged_items():
                         associationrow = {}
-                        self._synchronize(obj, child, associationrow, False)
+                        self._synchronize(obj, child, associationrow, False, uowcommit)
                         secondary_delete.append(associationrow)
         else:
             for obj in deplist:
@@ -304,11 +303,11 @@ class ManyToManyDP(DependencyProcessor):
                 if childlist is None: continue
                 for child in childlist.added_items():
                     associationrow = {}
-                    self._synchronize(obj, child, associationrow, False)
+                    self._synchronize(obj, child, associationrow, False, uowcommit)
                     secondary_insert.append(associationrow)
                 for child in childlist.deleted_items():
                     associationrow = {}
-                    self._synchronize(obj, child, associationrow, False)
+                    self._synchronize(obj, child, associationrow, False, uowcommit)
                     secondary_delete.append(associationrow)
         if len(secondary_delete):
             secondary_delete.sort()
@@ -330,7 +329,7 @@ class ManyToManyDP(DependencyProcessor):
                             uowcommit.register_object(child, isdelete=True)
                             for c in self.mapper.cascade_iterator('delete', child):
                                 uowcommit.register_object(c, isdelete=True)
-    def _synchronize(self, obj, child, associationrow, clearkeys):
+    def _synchronize(self, obj, child, associationrow, clearkeys, uowcommit):
         dest = associationrow
         source = None
         if dest is None:

diff --git a/lib/sqlalchemy/orm/sync.py b/lib/sqlalchemy/orm/sync.py
index 8d8ee4179378a02a626a9e19da8890f4e5cc2d58..4b9b0c35ced2865985b042cfee7c8b21b51f28f5 100644 (file)
--- a/lib/sqlalchemy/orm/sync.py
+++ b/lib/sqlalchemy/orm/sync.py
@@ -116,6 +116,7 @@ class SyncRule(object):
                 source = child
         if clearkeys or source is None:
             value = None
+            clearkeys = True
         else:
             value = self.source_mapper.get_attr_by_column(source, self.source_column)
         if isinstance(dest, dict):

diff --git a/test/orm/relationships.py b/test/orm/relationships.py
index d7fff287f8e918c27d81bacda6f2c11aa141d518..8cd682da21da7e002a53722c62b61cca718deeaa 100644 (file)
--- a/test/orm/relationships.py
+++ b/test/orm/relationships.py
@@ -350,8 +350,154 @@ class RelationTest3(testbase.PersistTest):
         j.pages[1].current_version = 12
         s.delete(j)
         s.flush()
+
+class RelationTest4(testbase.ORMTest):
+    """test syncrules on foreign keys that are also primary"""
+    def define_tables(self, metadata):
+        global tableA, tableB
+        tableA = Table("A", metadata, 
+            Column("id",Integer,primary_key=True),
+            Column("foo",Integer,),
+            )
+        tableB = Table("B",metadata,
+                Column("id",Integer,ForeignKey("A.id"),primary_key=True),
+                )
+    def test_no_delete_PK_AtoB(self):
+        """test that A cant be deleted without B because B would have no PK value"""
+        class A(object):pass
+        class B(object):pass
+        mapper(A, tableA, properties={
+            'bs':relation(B, cascade="save-update")
+        })
+        mapper(B, tableB)
+        a1 = A()
+        a1.bs.append(B())
+        sess = create_session()
+        sess.save(a1)
+        sess.flush()
         
+        sess.delete(a1)
+        try:
+            sess.flush()
+            assert False
+        except exceptions.AssertionError, e:
+            assert str(e).startswith("Dependency rule tried to blank-out primary key column 'B.id' on instance ")
+
+    def test_no_delete_PK_BtoA(self):
+        class A(object):pass
+        class B(object):pass
+        mapper(B, tableB, properties={
+            'a':relation(A, cascade="save-update")
+        })
+        mapper(A, tableA)
+        b1 = B()
+        a1 = A()
+        b1.a = a1
+        sess = create_session()
+        sess.save(b1)
+        sess.flush()
+        b1.a = None
+        try:
+            sess.flush()
+            assert False
+        except exceptions.AssertionError, e:
+            assert str(e).startswith("Dependency rule tried to blank-out primary key column 'B.id' on instance ")
+
+    def test_delete_cascade_BtoA(self):
+        """test that the 'blank the PK' error doesnt get raised when the child is to be deleted as part of a 
+        cascade"""
+        class A(object):pass
+        class B(object):pass
+        for cascade in (
+                    "save-update, delete",
+                    "save-update, delete-orphan",
+                    "save-update, delete, delete-orphan"):
+
+            mapper(B, tableB, properties={
+                'a':relation(A, cascade=cascade)
+            })
+            mapper(A, tableA)
+            b1 = B()
+            a1 = A()
+            b1.a = a1
+            sess = create_session()
+            sess.save(b1)
+            sess.flush()
+            sess.delete(b1)
+            sess.flush()
+            assert a1 not in sess
+            assert b1 not in sess
+            sess.clear()
+            clear_mappers()
+    
+    def test_delete_cascade_AtoB(self):
+        """test that the 'blank the PK' error doesnt get raised when the child is to be deleted as part of a 
+        cascade"""
+        class A(object):pass
+        class B(object):pass
+        for cascade in (
+                    "save-update, delete",
+                    "save-update, delete-orphan",
+                    "save-update, delete, delete-orphan"):
+            mapper(A, tableA, properties={
+                'bs':relation(B, cascade=cascade)
+            })
+            mapper(B, tableB)
+            a1 = A()
+            b1 = B()
+            a1.bs.append(b1)
+            sess = create_session()
+            sess.save(a1)
+            sess.flush()
         
-        
+            sess.delete(a1)
+            sess.flush()
+            assert a1 not in sess
+            assert b1 not in sess
+            sess.clear()
+            clear_mappers()
+    
+    def test_delete_manual_AtoB(self):
+        class A(object):pass
+        class B(object):pass
+        mapper(A, tableA, properties={
+            'bs':relation(B, cascade="none")
+        })
+        mapper(B, tableB)
+        a1 = A()
+        b1 = B()
+        a1.bs.append(b1)
+        sess = create_session()
+        sess.save(a1)
+        sess.save(b1)
+        sess.flush()
+    
+        sess.delete(a1)
+        sess.delete(b1)
+        sess.flush()
+        assert a1 not in sess
+        assert b1 not in sess
+        sess.clear()
+
+    def test_delete_manual_BtoA(self):
+        class A(object):pass
+        class B(object):pass
+        mapper(B, tableB, properties={
+            'a':relation(A, cascade="none")
+        })
+        mapper(A, tableA)
+        b1 = B()
+        a1 = A()
+        b1.a = a1
+        sess = create_session()
+        sess.save(b1)
+        sess.save(a1)
+        sess.flush()
+        sess.delete(b1)
+        sess.delete(a1)
+        sess.flush()
+        assert a1 not in sess
+        assert b1 not in sess
+    
 if __name__ == "__main__":
     testbase.main()