codegen: Detect usage of static type-parameter in runtime context

Compact classes doesn't carry runtime information of its type-parameters.
In case this information is required we need report an error.

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1326

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 4c7e0f73c60fff175af3733beaffb8896bd4e4c4..19fcd52a9d6af2b90b0b2ac4f4b7576e2cc83f1e 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -2839,6 +2839,12 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
        public CCodeExpression get_type_id_expression (DataType type, bool is_chainup = false) {
                if (type is GenericType) {
                        var type_parameter = ((GenericType) type).type_parameter;
+                       unowned Symbol? parent = type_parameter.owner.owner;
+                       if (parent is Class && ((Class) parent).is_compact) {
+                               Report.error (type.source_reference, "static type-parameter `%s' can not be used in runtime context".printf (type_parameter.get_full_name ()));
+                               return new CCodeInvalidExpression();
+                       }
+
                        string var_name = "%s_type".printf (type_parameter.name.ascii_down ());
 
                        if (type_parameter.parent_symbol is Interface) {

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 0e4500b572a7e0af00a7c97aac301da9020b3fea..6ac21af779a6d74771bdcf69f33525898c2872b8 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -732,6 +732,7 @@ TESTS = \
        generics/string-literal-comparison.vala \
        generics/type-parameter-properties.vala \
        generics/type-parameter-property-clash.vala \
+       generics/type-parameter-static-in-runtime.test \
        generics/value-pointer-type-access.vala \
        generics/bug640330.vala \
        generics/bug640330-2.test \

diff --git a/tests/generics/type-parameter-static-in-runtime.test b/tests/generics/type-parameter-static-in-runtime.test
new file mode 100644 (file)
index 0000000..f6b6317
--- /dev/null
+++ b/tests/generics/type-parameter-static-in-runtime.test
@@ -0,0 +1,14 @@
+Invalid Code
+
+[Compact]
+class Foo<T> {
+       public Bar<T> bar () {
+               return new Bar<T> ();
+       }
+}
+
+class Bar<T> {
+}
+
+void main () {
+}