logging: include <syslog.h>

Move the inclusion of <syslog.h> from sysincl.h to logging.c to avoid
accidentally using the LOG_* constants from the header.

diff --git a/logging.c b/logging.c
index 1993ab724c16f3b7a2a73219c15eec3c10b392ea..9da14faa455fe8d7df6e0c72c8c63b8ad8fe2df6 100644 (file)
--- a/logging.c
+++ b/logging.c
@@ -29,6 +29,8 @@
 
 #include "sysincl.h"
 
+#include <syslog.h>
+
 #include "conf.h"
 #include "logging.h"
 #include "util.h"

diff --git a/sysincl.h b/sysincl.h
index 296c5e6820058705c136813ab037624a10178314..b27afa07e05bb8289a67a1690c9d06f15b887dc8 100644 (file)
--- a/sysincl.h
+++ b/sysincl.h
@@ -21,9 +21,8 @@
 
   =======================================================================
 
-  This file includes all system header files that the software
-  requires.  This allows us to isolate system dependencies to this file
-  alone.
+  This file includes most system header files that the software
+  requires to better isolate system dependencies.
   */
 
 #ifndef GOT_SYSINCL_H
@@ -54,7 +53,6 @@
 #include <sys/un.h>
 #include <sys/shm.h>
 #include <sys/wait.h>
-#include <syslog.h>
 #include <time.h>
 #include <unistd.h>