]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: hisilicon/zip - remove unnecessary validation for high-performance mode confi...
authorChenghai Huang <huangchenghai2@huawei.com>
Thu, 21 Aug 2025 01:38:04 +0000 (09:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2025 09:56:31 +0000 (11:56 +0200)
[ Upstream commit d4e081510471e79171c4e0a11f6cb608e49bc082 ]

When configuring the high-performance mode register, there is no
need to verify whether the register has been successfully
enabled, as there is no possibility of a write failure for this
register.

Fixes: a9864bae1806 ("crypto: hisilicon/zip - add zip comp high perf mode configuration")
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/hisilicon/zip/zip_main.c

index 86e517812093605fb1bdfd864597f9e1f9291f9f..4e10090067f1843a30274a530702c359fed94251 100644 (file)
@@ -470,10 +470,9 @@ bool hisi_zip_alg_support(struct hisi_qm *qm, u32 alg)
        return false;
 }
 
-static int hisi_zip_set_high_perf(struct hisi_qm *qm)
+static void hisi_zip_set_high_perf(struct hisi_qm *qm)
 {
        u32 val;
-       int ret;
 
        val = readl_relaxed(qm->io_base + HZIP_HIGH_PERF_OFFSET);
        if (perf_mode == HZIP_HIGH_COMP_PERF)
@@ -483,13 +482,6 @@ static int hisi_zip_set_high_perf(struct hisi_qm *qm)
 
        /* Set perf mode */
        writel(val, qm->io_base + HZIP_HIGH_PERF_OFFSET);
-       ret = readl_relaxed_poll_timeout(qm->io_base + HZIP_HIGH_PERF_OFFSET,
-                                        val, val == perf_mode, HZIP_DELAY_1_US,
-                                        HZIP_POLL_TIMEOUT_US);
-       if (ret)
-               pci_err(qm->pdev, "failed to set perf mode\n");
-
-       return ret;
 }
 
 static void hisi_zip_open_sva_prefetch(struct hisi_qm *qm)
@@ -1181,9 +1173,7 @@ static int hisi_zip_pf_probe_init(struct hisi_zip *hisi_zip)
        if (ret)
                return ret;
 
-       ret = hisi_zip_set_high_perf(qm);
-       if (ret)
-               return ret;
+       hisi_zip_set_high_perf(qm);
 
        hisi_zip_open_sva_prefetch(qm);
        hisi_qm_dev_err_init(qm);