]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: echoaudio: Replace deprecated strcpy() with strscpy()
authorThorsten Blum <thorsten.blum@linux.dev>
Wed, 9 Jul 2025 12:46:52 +0000 (14:46 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 9 Jul 2025 14:03:29 +0000 (16:03 +0200)
strcpy() is deprecated; use strscpy() instead.

No functional changes intended.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250709124655.1195-1-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio.c

index 80d8ce75fdbb32a0fd0fee8b5777b46beabbce44..2b33ef588ac31eca6d05833c3e3242349cac01d4 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/string.h>
 
 MODULE_AUTHOR("Giuliano Pochini <pochini@shiny.it>");
 MODULE_LICENSE("GPL v2");
@@ -916,7 +917,7 @@ static int snd_echo_new_pcm(struct echoaudio *chip)
                return err;
        pcm->private_data = chip;
        chip->analog_pcm = pcm;
-       strcpy(pcm->name, chip->card->shortname);
+       strscpy(pcm->name, chip->card->shortname);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &analog_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &analog_capture_ops);
        snd_echo_preallocate_pages(pcm, &chip->pci->dev);
@@ -929,7 +930,7 @@ static int snd_echo_new_pcm(struct echoaudio *chip)
                return err;
        pcm->private_data = chip;
        chip->digital_pcm = pcm;
-       strcpy(pcm->name, chip->card->shortname);
+       strscpy(pcm->name, chip->card->shortname);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &digital_capture_ops);
        snd_echo_preallocate_pages(pcm, &chip->pci->dev);
 #endif /* ECHOCARD_HAS_DIGITAL_IO */
@@ -949,7 +950,7 @@ static int snd_echo_new_pcm(struct echoaudio *chip)
                return err;
        pcm->private_data = chip;
        chip->analog_pcm = pcm;
-       strcpy(pcm->name, chip->card->shortname);
+       strscpy(pcm->name, chip->card->shortname);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &analog_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &analog_capture_ops);
        snd_echo_preallocate_pages(pcm, &chip->pci->dev);
@@ -963,7 +964,7 @@ static int snd_echo_new_pcm(struct echoaudio *chip)
                return err;
        pcm->private_data = chip;
        chip->digital_pcm = pcm;
-       strcpy(pcm->name, chip->card->shortname);
+       strscpy(pcm->name, chip->card->shortname);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &digital_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &digital_capture_ops);
        snd_echo_preallocate_pages(pcm, &chip->pci->dev);
@@ -1985,8 +1986,8 @@ static int __snd_echo_probe(struct pci_dev *pci,
        if (err < 0)
                return err;
 
-       strcpy(card->driver, "Echo_" ECHOCARD_NAME);
-       strcpy(card->shortname, chip->card_name);
+       strscpy(card->driver, "Echo_" ECHOCARD_NAME);
+       strscpy(card->shortname, chip->card_name);
 
        dsp = "56301";
        if (pci_id->device == 0x3410)