]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx()
authorJaeJoon Jung <rgbi3307@gmail.com>
Tue, 16 Dec 2025 07:34:38 +0000 (23:34 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 21 Jan 2026 03:24:46 +0000 (19:24 -0800)
The damon_stat_build_ctx() function sets the values of intervals_goal
structure members.  These values are applied to damon_ctx in
damon_set_attrs().  However, It is resetting the values that were already
applied previously to the same values.  I suggest removing this code as it
constitutes duplicate execution.

Link: https://patch.msgid.link/20251206011716.7185-1-rgbi3307@gmail.com
Link: https://lkml.kernel.org/r/20251216073440.40891-1-sj@kernel.org
Signed-off-by: JaeJoon Jung <rgbi3307@gmail.com>
Reviewed-by: Enze Li <lienze@kylinos.cn>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/stat.c

index ed8e3629d31a43db4bd6b5c80ee4cf1fe15e6a1f..ef0a1195a58499680e8e2579dd32d8b87b304a48 100644 (file)
@@ -173,14 +173,6 @@ static struct damon_ctx *damon_stat_build_ctx(void)
        if (damon_set_attrs(ctx, &attrs))
                goto free_out;
 
-       /*
-        * auto-tune sampling and aggregation interval aiming 4% DAMON-observed
-        * accesses ratio, keeping sampling interval in [5ms, 10s] range.
-        */
-       ctx->attrs.intervals_goal = (struct damon_intervals_goal) {
-               .access_bp = 400, .aggrs = 3,
-               .min_sample_us = 5000, .max_sample_us = 10000000,
-       };
        if (damon_select_ops(ctx, DAMON_OPS_PADDR))
                goto free_out;