BUG/MINOR: ssl: memory leak in crtlist_parse_file()

A memory leak happens in an error case when ckchs_load_cert_file()
returns NULL in crtlist_parse_file().

This bug was introduced by commit 2954c47 ("MEDIUM: ssl: allow crt-list caching")

This patch fixes bug #551.

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 8d3434a114f73cdb283537f02520690893d06e73..2c7892c163bf21f1bc8e3240f14855f5ec3c4118 100644 (file)
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -4846,10 +4846,8 @@ static int crtlist_parse_file(char *file, struct bind_conf *bind_conf, struct pr
                        else
                                ckchs = ckchs_load_cert_file(crt_path, 1,  err);
                }
-               if (ckchs == NULL) {
+               if (ckchs == NULL)
                        cfgerr |= ERR_ALERT | ERR_FATAL;
-                       goto error;
-               }
 
                entry = malloc(sizeof(*entry));
                if (entry == NULL) {