]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
More connection_t related UBSAN false positives
authorNick Porter <nick@portercomputing.co.uk>
Wed, 4 Sep 2024 10:40:14 +0000 (11:40 +0100)
committerNick Porter <nick@portercomputing.co.uk>
Wed, 4 Sep 2024 10:40:14 +0000 (11:40 +0100)
src/lib/ldap/connection.c
src/lib/redis/io.c
src/modules/rlm_logtee/rlm_logtee.c
src/modules/rlm_radius/rlm_radius_udp.c
src/modules/rlm_sql/drivers/rlm_sql_mysql/rlm_sql_mysql.c
src/modules/rlm_sql/drivers/rlm_sql_postgresql/rlm_sql_postgresql.c

index b0bf7f54be5b14c40c01fb8a8ec4f1db28e0ff18..8094c169d6e3ec26055f2d89b13791524b99768c 100644 (file)
@@ -338,6 +338,7 @@ static void _ldap_connection_close_watch(connection_t *conn, UNUSED connection_s
  *     - CONNECTION_STATE_CONNECTING on success.
  *     - CONNECTION_STATE_FAILED on failure.
  */
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t _ldap_connection_init(void **h, connection_t *conn, void *uctx)
 {
        fr_ldap_config_t const  *config = uctx;
index 9e873dabd9cdd6938f3ad99f84ffeaa65e6c09ad..476aefdc5a50be87eb41c4af3de90d63bcfa9a3b 100644 (file)
@@ -302,6 +302,7 @@ static int _redis_handle_free(fr_redis_handle_t *h)
  *     - #CONNECTION_STATE_CONNECTING  if a file descriptor was successfully created.
  *     - #CONNECTION_STATE_FAILED              if we could not open a valid handle.
  */
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t _redis_io_connection_init(void **h_out, connection_t *conn, void *uctx)
 {
        fr_redis_io_conf_t      *conf = uctx;
index b32db1099cf078fbcac0aa18b3e7cf0e04c7a4e9..6893a40d066975062bf3ea885e90d3b7659add3d 100644 (file)
@@ -387,6 +387,7 @@ static connection_state_t _logtee_conn_open(UNUSED fr_event_list_t *el, UNUSED v
  * @param[in] conn     being initialised.
  * @param[in] uctx     A #rlm_logtee_thread_t.
  */
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t _logtee_conn_init(void **h_out, connection_t *conn, void *uctx)
 {
        rlm_logtee_thread_t     *t = talloc_get_type_abort(uctx, rlm_logtee_thread_t);
index 3dd3bfa56ddc32e24b388443469afc8b66d6d261..41fa0cd9936b75eafe0ff02f69f0058c41552e85 100644 (file)
@@ -709,6 +709,7 @@ static int _udp_handle_free(udp_handle_t *h)
  * @param[in] conn     to initialise.
  * @param[in] uctx     A #udp_thread_t
  */
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t conn_init(void **h_out, connection_t *conn, void *uctx)
 {
        int                     fd;
index d42cadcd426dc820b1436682f41aa37f57b558c1..7f708ab769cd2daad29c04db9fd6c9cdc125d84e 100644 (file)
@@ -251,6 +251,7 @@ static void _sql_connect_query_run(connection_t *conn, UNUSED connection_state_t
        }
 }
 
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t _sql_connection_init(void **h, connection_t *conn, void *uctx)
 {
        rlm_sql_t const         *sql = talloc_get_type_abort_const(uctx, rlm_sql_t);
@@ -840,6 +841,7 @@ static size_t sql_escape_func(UNUSED request_t *request, char *out, size_t outle
  * @param[in] log_prefix       What to prefix log messages with.
  * @param[in] uctx             User context passed to trunk_alloc.
  */
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_t *sql_trunk_connection_alloc(trunk_connection_t *tconn, fr_event_list_t *el,
                                                   connection_conf_t const *conn_conf,
                                                   char const *log_prefix, void *uctx)
index 31dcaacc250914217669801630eb8e7812609751..304994a144c5d662c4d541d8f9155323f0670324 100644 (file)
@@ -267,6 +267,7 @@ static void _sql_connect_io_notify(fr_event_list_t *el, int fd, UNUSED int flags
        }
 }
 
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_state_t _sql_connection_init(void **h, connection_t *conn, void *uctx)
 {
        rlm_sql_t const                 *sql = talloc_get_type_abort_const(uctx, rlm_sql_t);
@@ -342,6 +343,7 @@ static void _sql_connection_close(fr_event_list_t *el, void *h, UNUSED void *uct
        talloc_free(h);
 }
 
+CC_NO_UBSAN(function) /* UBSAN: false positive - public vs private connection_t trips --fsanitize=function*/
 static connection_t *sql_trunk_connection_alloc(trunk_connection_t *tconn, fr_event_list_t *el,
                                                connection_conf_t const *conn_conf,
                                                char const *log_prefix, void *uctx)