]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:utils:status_json fix Non-boolean returned
authorGary Lockyer <gary@catalyst.net.nz>
Thu, 15 Jan 2026 03:10:04 +0000 (16:10 +1300)
committerAnoop C S <anoopcs@samba.org>
Thu, 15 Jan 2026 09:18:21 +0000 (09:18 +0000)
Fix cppcheck

source3/utils/status_json.c:1385:3: style: Non-boolean value returned
    from function returning bool [returnNonBoolInBooleanFunction]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Thu Jan 15 09:18:21 UTC 2026 on atb-devel-224

source3/utils/status_json.c

index fba0f40508f7c0331c9bf7590a4c0586c8cfdffd..169cea69960880de629c15ce6a982bbd7ace9f67 100644 (file)
@@ -1383,7 +1383,7 @@ bool print_notify_rec_json(struct traverse_state *state,
 
        TALLOC_CTX *tmp_ctx = talloc_stackframe();
        if (tmp_ctx == NULL) {
-               return -1;
+               return false;
        }
 
        sub_json = json_new_object();