]> git.ipfire.org Git - thirdparty/coreutils.git/commitdiff
(check-AUTHORS): Don't assume \? works in a sed
authorPaul Eggert <eggert@cs.ucla.edu>
Wed, 3 Nov 2004 23:12:55 +0000 (23:12 +0000)
committerPaul Eggert <eggert@cs.ucla.edu>
Wed, 3 Nov 2004 23:12:55 +0000 (23:12 +0000)
expression; it's not portable.  Problem reported by Albert Chin.
Don't invoke a program more than once.

src/Makefile.am

index 32956979983c578f74c1ea3dcc857ae42d5e8a9f..d1c039f0c1a9c70e449267e09a274713b9993af6 100644 (file)
@@ -248,7 +248,7 @@ au_actual = authors-actual
 .PHONY: check-AUTHORS
 check-AUTHORS: $(all_programs)
        rm -f $(au_actual) $(au_dotdot)
-       for i in $(all_programs); do                    \
+       for i in `ls $(all_programs) | $(ASSORT) -u`; do \
          test "$$i" = '[' && continue;                 \
          exe=$$i;                                      \
          if test "$$i" = install; then                 \
@@ -256,11 +256,9 @@ check-AUTHORS: $(all_programs)
          elif test "$$i" = test; then                  \
            exe='[';                                    \
          fi;                                           \
-         ./printf "$$i: ";                             \
          ./$$exe --version                             \
-           |sed -n '/Written by /s///p'                \
-           |sed 's/,\? and /, /;s/\.$$//';             \
-       done | $(ASSORT) > $(au_actual)
+           |sed -n '/Written by /{ s//'"$$i"': /; s/,* and /, /; s/\.$$//; p; }'; \
+       done > $(au_actual)
        sed -n '/:/p' $(top_srcdir)/AUTHORS > $(au_dotdot)
        diff $(au_actual) $(au_dotdot) && rm -f $(au_actual) $(au_dotdot)