hwclock: don't warp the systemtime if the RTC is in UTC

A sideeffect of 839be2ba6b44fa9dc927f081d547ebadec9de19c is that we now
warp the systemtime according to the timezone, on the first call of
--systz. This is not always the correct thing to do, and causes a
regression for us in Arch Linux.

The behavior is correct if the RTC, and hence the systemtime, is
in localtime. However, if the systemtime is already in UTC we don't
want to touch it when we set the kernel timezone (which we still need to
do as some filesystems use this information).

An almost identical issue was also fixed in systemd commit
72edcff5db936e54cfc322d9392ec46e2428fd9b.

Signed-off-by: Tom Gundersen <teg@jklm.no>

diff --git a/sys-utils/hwclock.8 b/sys-utils/hwclock.8
index 07d9fc02439003c8e10e2dc6d62a2eef035d198e..5c599ad76afaf520f7e9f0ed7f0ab8f49f43ef05 100644 (file)
--- a/sys-utils/hwclock.8
+++ b/sys-utils/hwclock.8
@@ -58,10 +58,12 @@ This is a good option to use in one of the system startup scripts.
 Set the Hardware Clock to the current System Time.
 .TP
 .B \-\-systz
-Reset the System Time based on the current timezone.
+Set the kernel's timezone and reset the System Time based on the current timezone.
 
-Also set the kernel's timezone value to the local timezone
-as indicated by the TZ environment variable and/or
+The system time is only reset on the first call after boot.
+
+The local timezone is taken to be what is
+indicated by the TZ environment variable and/or
 .IR /usr/share/zoneinfo ,
 as
 .BR tzset (3)
@@ -74,7 +76,8 @@ This is an alternate option to
 .B \-\-hctosys
 that does not read the hardware clock, and may be used in system startup
 scripts for recent 2.6 kernels where you know the System Time contains
-the Hardware Clock time.
+the Hardware Clock time. If the Hardware Clock is already in UTC, it is
+not reset.
 .TP
 .B \-\-adjust
 Add or subtract time from the Hardware Clock to account for systematic

diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 5a4c87e288aa9a58f0225da25b30b0a31eef3b4e..351ce1f37152a67528b6133a153f32ea0bbb61b7 100644 (file)
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -772,7 +772,6 @@ static int set_system_clock_timezone(const bool universal, const bool testing)
        struct timeval tv;
        struct tm *broken;
        int minuteswest;
-       int rc;
 
        gettimeofday(&tv, NULL);
        if (debug) {
@@ -818,10 +817,24 @@ static int set_system_clock_timezone(const bool universal, const bool testing)
                       ("Not setting system clock because running in test mode.\n"));
                retcode = 0;
        } else {
+               const struct timezone tz_utc = { 0, 0 };
                const struct timezone tz = { minuteswest, 0 };
                const struct timeval *tv_null = NULL;
+               int rc = 0;
+
+               /* The first call to settimeofday after boot will assume the systemtime
+                * is in localtime, and adjust it according to the given timezone to
+                * compensate. If the systemtime is in fact in UTC, then this is wrong
+                * so we first do a dummy call to make sure the time is not shifted.
+                */
+               if (universal)
+                       rc = settimeofday(tv_null, &tz_utc);
+
+               /* Now we set the real timezone. Due to the above dummy call, this will
+                * only warp the systemtime if the RTC is not in UTC. */
+               if (!rc)
+                       rc = settimeofday(tv_null, &tz);
 
-               rc = settimeofday(tv_null, &tz);
                if (rc) {
                        if (errno == EPERM) {
                                warnx(_