selftests: mptcp: join chk_stale_nr: avoid dup stats

nstat outputs are already printed when calling 'fail_test', no need to
do it again.

While at it, no need to use the dump_stats variable, print the extra
stats directly. And use 'ip -n $ns' instead of 'ip netns exec $ns',
shorter and clearer.

Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260203-net-next-mptcp-misc-feat-6-20-v1-12-31ec8bfc56d1@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 4977e6ff17b45aa4da39d37c17dc2658bfdbfd84..a8b9782a85df828f9488d3620f09c7314786858a 100755 (executable)
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -1648,7 +1648,6 @@ chk_stale_nr()
        local stale_min=$2
        local stale_max=$3
        local stale_delta=$4
-       local dump_stats
        local stale_nr
        local recover_nr
 
@@ -1664,16 +1663,11 @@ chk_stale_nr()
                fail_test "got $stale_nr stale[s] $recover_nr recover[s], " \
                     " expected stale in range [$stale_min..$stale_max]," \
                     " stale-recover delta $stale_delta"
-               dump_stats=1
+               echo $ns stats
+               ip -n $ns -s link show
        else
                print_ok
        fi
-
-       if [ "${dump_stats}" = 1 ]; then
-               echo $ns stats
-               ip netns exec $ns ip -s link show
-               ip netns exec $ns nstat -as | grep MPTcp
-       fi
 }
 
 chk_add_nr()