]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Prevent bad calls to get_arguments with a presumed default value 1371/head
authorYusuf Simonson <simonson@gmail.com>
Sat, 7 Mar 2015 17:34:37 +0000 (12:34 -0500)
committerYusuf Simonson <simonson@gmail.com>
Sat, 7 Mar 2015 17:34:37 +0000 (12:34 -0500)
tornado/web.py

index f4e8a84aa063e947e9cc05cd74a25763f62ae56c..6d37f70503395066340749dbd212f4bcfab0fb65 100644 (file)
@@ -392,6 +392,12 @@ class RequestHandler(object):
 
         The returned values are always unicode.
         """
+
+        # Make sure `get_arguments` isn't accidentally being called with a
+        # positional argument that's assumed to be a default (like in
+        # `get_argument`.)
+        assert isinstance(strip, bool)
+
         return self._get_arguments(name, self.request.arguments, strip)
 
     def get_body_argument(self, name, default=_ARG_DEFAULT, strip=True):