]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Fix some code that wrongly assumed a pointer would always be non-NULL when dealing...
authorJoshua Colp <jcolp@digium.com>
Wed, 20 May 2009 17:30:25 +0000 (17:30 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 20 May 2009 17:30:25 +0000 (17:30 +0000)
(closes issue #15079)
Reported by: barryf

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@195688 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_features.c

index 00bacaa936db386636d66eedc7b4fbdfaaf43647..cf2b8669dc0f6da4c73c14f07bbe0ab3c6e8e7cb 100644 (file)
@@ -1760,15 +1760,21 @@ int ast_bridge_call(struct ast_channel *chan,struct ast_channel *peer,struct ast
                   hears nothing but ringing while the macro does its thing. */
                if (peer_cdr && !ast_tvzero(peer_cdr->answer)) {
                        bridge_cdr->answer = peer_cdr->answer;
-                       chan_cdr->answer = peer_cdr->answer;
                        bridge_cdr->disposition = peer_cdr->disposition;
-                       chan_cdr->disposition = peer_cdr->disposition;
+                       if (chan_cdr) {
+                               chan_cdr->answer = peer_cdr->answer;
+                               chan_cdr->disposition = peer_cdr->disposition;
+                       }
                } else {
                        ast_cdr_answer(bridge_cdr);
-                       ast_cdr_answer(chan_cdr); /* for the sake of cli status checks */
+                       if (chan_cdr) {
+                               ast_cdr_answer(chan_cdr); /* for the sake of cli status checks */
+                       }
                }
-               if (ast_test_flag(chan,AST_FLAG_BRIDGE_HANGUP_DONT)) {
-                       ast_set_flag(chan_cdr, AST_CDR_FLAG_BRIDGED);
+               if (ast_test_flag(chan,AST_FLAG_BRIDGE_HANGUP_DONT) && (chan_cdr || peer_cdr)) {
+                       if (chan_cdr) {
+                               ast_set_flag(chan_cdr, AST_CDR_FLAG_BRIDGED);
+                       }
                        if (peer_cdr) {
                                ast_set_flag(peer_cdr, AST_CDR_FLAG_BRIDGED);
                        }