]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
vxlan: remove redundant conversion of vni in vxlan_nl2conf
authorWang Liang <wangliang74@huawei.com>
Tue, 22 Jul 2025 09:30:49 +0000 (17:30 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 24 Jul 2025 00:09:29 +0000 (17:09 -0700)
The IFLA_VXLAN_ID data has been converted to local variable vni in
vxlan_nl2conf(), there is no need to do it again when set conf->vni.

Signed-off-by: Wang Liang <wangliang74@huawei.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20250722093049.1527505-1-wangliang74@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/vxlan/vxlan_core.c

index bcde95cb2a2ec174007e36d7906385d408b6f704..f32be2e301f26587684073baf15e352335bc730a 100644 (file)
@@ -4041,7 +4041,7 @@ static int vxlan_nl2conf(struct nlattr *tb[], struct nlattr *data[],
                        NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_ID], "Cannot change VNI");
                        return -EOPNOTSUPP;
                }
-               conf->vni = cpu_to_be32(nla_get_u32(data[IFLA_VXLAN_ID]));
+               conf->vni = vni;
        }
 
        if (data[IFLA_VXLAN_GROUP]) {