]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qedi: Remove unused sysfs functions
authorDr. David Alan Gilbert <linux@treblig.org>
Wed, 16 Apr 2025 00:22:34 +0000 (01:22 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 22 Apr 2025 01:51:08 +0000 (21:51 -0400)
qedi_remove_sysfs_attr() and qedi_create_sysfs_attr() were added in 2016
by commit ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI
driver framework.")  but have remained unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20250416002235.299347-2-linux@treblig.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedi/qedi_dbg.c
drivers/scsi/qedi/qedi_dbg.h

index 2ebef4d20b5b95ff169b771e33c519a035981e7b..2f3e044b818f7483317dafbc9f885421797da819 100644 (file)
@@ -103,25 +103,3 @@ qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
 ret:
        va_end(va);
 }
-
-int
-qedi_create_sysfs_attr(struct Scsi_Host *shost, struct sysfs_bin_attrs *iter)
-{
-       int ret = 0;
-
-       for (; iter->name; iter++) {
-               ret = sysfs_create_bin_file(&shost->shost_gendev.kobj,
-                                           iter->attr);
-               if (ret)
-                       pr_err("Unable to create sysfs %s attr, err(%d).\n",
-                              iter->name, ret);
-       }
-       return ret;
-}
-
-void
-qedi_remove_sysfs_attr(struct Scsi_Host *shost, struct sysfs_bin_attrs *iter)
-{
-       for (; iter->name; iter++)
-               sysfs_remove_bin_file(&shost->shost_gendev.kobj, iter->attr);
-}
index 5a1ec45421834bfed5f7d7b87391ae8cc4905c6e..8649518658691eeebd7299b750c51511ddfde8b9 100644 (file)
@@ -87,18 +87,6 @@ void qedi_dbg_notice(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
 void qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
                   u32 info, const char *fmt, ...);
 
-struct Scsi_Host;
-
-struct sysfs_bin_attrs {
-       char *name;
-       const struct bin_attribute *attr;
-};
-
-int qedi_create_sysfs_attr(struct Scsi_Host *shost,
-                          struct sysfs_bin_attrs *iter);
-void qedi_remove_sysfs_attr(struct Scsi_Host *shost,
-                           struct sysfs_bin_attrs *iter);
-
 /* DebugFS related code */
 struct qedi_list_of_funcs {
        char *oper_str;