]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 23 Sep 2024 20:48:53 +0000 (23:48 +0300)
committerHelge Deller <deller@gmx.de>
Sun, 27 Jul 2025 17:56:51 +0000 (19:56 +0200)
Invert fbcon_cursor_noblink into fbcon_cursor_blink so that:
- it matches the sysfs attribute exactly
- avoids having to do these NOT operations all over the place
- use bool instead of int

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/core/fbcon.c

index 2df48037688d1df5a2754d3d8b82f7fc418f6960..83b42f72455909e6b3be7ca7d2c1bb567b4f81c9 100644 (file)
@@ -171,7 +171,7 @@ static const struct consw fb_con;
 
 #define advance_row(p, delta) (unsigned short *)((unsigned long)(p) + (delta) * vc->vc_size_row)
 
-static int fbcon_cursor_noblink;
+static bool fbcon_cursor_blink = true;
 
 #define divides(a, b)  ((!(a) || (b)%(a)) ? 0 : 1)
 
@@ -406,7 +406,7 @@ static void fbcon_add_cursor_work(struct fb_info *info)
 {
        struct fbcon_ops *ops = info->fbcon_par;
 
-       if (!fbcon_cursor_noblink)
+       if (fbcon_cursor_blink)
                queue_delayed_work(system_power_efficient_wq, &ops->cursor_work,
                                   ops->cur_blink_jiffies);
 }
@@ -3273,10 +3273,10 @@ static ssize_t cursor_blink_store(struct device *device,
        blink = simple_strtoul(buf, last, 0);
 
        if (blink) {
-               fbcon_cursor_noblink = 0;
+               fbcon_cursor_blink = true;
                fbcon_add_cursor_work(info);
        } else {
-               fbcon_cursor_noblink = 1;
+               fbcon_cursor_blink = false;
                fbcon_del_cursor_work(info);
        }