]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ACPI: scan: Do not mark button ACPI devices as wakeup-capable
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 15 Dec 2025 14:00:57 +0000 (15:00 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 26 Dec 2025 14:08:57 +0000 (15:08 +0100)
It is generally questionable to mark struct acpi_device "devices" as
wakeup-capable because they represent firmware entities that by
themselves have no wakeup capabilities.

It was done for struct acpi_device "devices" corresponding to buttons
because the ACPI button driver was binding to them directly, but now
that corresponding platform devices are created for the buttons and
they are marked as wakeup-capable by the ACPI button driver, there is
no reason to continue doing it.

Update acpi_wakeup_gpe_init() accordingly.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2891119.BEx9A2HvPv@rafael.j.wysocki
drivers/acpi/scan.c

index 1bc470019298fde7a4269de0bce440ebd18e633b..37f06d7e97c564c7668cea81af0a81d767ae39af 100644 (file)
@@ -1023,7 +1023,6 @@ static bool acpi_wakeup_gpe_init(struct acpi_device *device)
                    wakeup->sleep_state == ACPI_STATE_S5)
                        wakeup->sleep_state = ACPI_STATE_S4;
                acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number);
-               device_set_wakeup_capable(&device->dev, true);
                return true;
        }