media: v4l: Memset argument to 0 before calling get_mbus_config pad op

Memset the config argument to get_mbus_config V4L2 sub-device pad
operation to zero before calling the operation. This ensures the callers
don't need to bother with it nor the implementations need to set all
fields that may not be relevant to them.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index cde1774c9098dd0bf2f1232bd3e929f4c9026612..a3074f469b1503880845bfb953cc2b69807f6746 100644 (file)
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -444,6 +444,8 @@ static int call_enum_dv_timings(struct v4l2_subdev *sd,
 static int call_get_mbus_config(struct v4l2_subdev *sd, unsigned int pad,
                                struct v4l2_mbus_config *config)
 {
+       memset(config, 0, sizeof(*config));
+
        return check_pad(sd, pad) ? :
               sd->ops->pad->get_mbus_config(sd, pad, config);
 }

diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 2f2200875b03844a94b9ac95ed1b0b867a35d699..57f2bcb4eb16c3371d98683e4aa72b85bbe932d4 100644 (file)
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -822,7 +822,9 @@ struct v4l2_subdev_state {
  *                  possible configuration from the remote end, likely calling
  *                  this operation as close as possible to stream on time. The
  *                  operation shall fail if the pad index it has been called on
- *                  is not valid or in case of unrecoverable failures.
+ *                  is not valid or in case of unrecoverable failures. The
+ *                  config argument has been memset to 0 just before calling
+ *                  the op.
  *
  * @set_routing: Enable or disable data connection routes described in the
  *              subdevice routing table. Subdevs that implement this operation