utils: defensive programming

If caller passed the size of array not string length, it is possible to be accessed out of bounds.

Reorder conditions can prevent access invalid index of array.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 77ad76b498b2edc5548612009c1644df9d29bc8e..9795b51b668a1978c803c10c672b43218dc216e8 100644 (file)
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -898,10 +898,10 @@ static char *get_nextpath(char *path, int *offsetp, int fulllen)
        if (offset >= fulllen)
                return NULL;
 
-       while (path[offset] != '\0' && offset < fulllen)
+       while (offset < fulllen && path[offset] != '\0')
                offset++;
 
-       while (path[offset] == '\0' && offset < fulllen)
+       while (offset < fulllen && path[offset] == '\0')
                offset++;
 
        *offsetp = offset;