[458-config-backend-support-in-src-lib] Addressed comments

diff --git a/src/lib/dhcpsrv/Makefile.am b/src/lib/dhcpsrv/Makefile.am
index 383760e442207617bf0d887d8b507aa288c2c9f1..e72952892eb3994b31ebf650ead281568b986591 100644 (file)
--- a/src/lib/dhcpsrv/Makefile.am
+++ b/src/lib/dhcpsrv/Makefile.am
@@ -281,8 +281,11 @@ libkea_dhcpsrv_include_HEADERS = \
        cfgmgr.h \
        client_class_def.h \
        config_backend_dhcp4.h \
+       config_backend_dhcp6.h \
        config_backend_dhcp4_mgr.h \
+       config_backend_dhcp6_mgr.h \
        config_backend_pool_dhcp4.h \
+       config_backend_pool_dhcp6.h \
        csv_lease_file4.h \
        csv_lease_file6.h \
        dhcpsrv_exceptions.h \

diff --git a/src/lib/dhcpsrv/config_backend_dhcp4.h b/src/lib/dhcpsrv/config_backend_dhcp4.h
index 9b0b3d49a40621eee78a6a754a94883e1ff6a9c2..338a8db9705e5344793289d8a07776caea21e64e 100644 (file)
--- a/src/lib/dhcpsrv/config_backend_dhcp4.h
+++ b/src/lib/dhcpsrv/config_backend_dhcp4.h
@@ -151,7 +151,7 @@ public:
     virtual OptionContainer
     getAllOptions4(const db::ServerSelector& server_selector) const = 0;
 
-    /// @brief Retrieves option modified after specified time.
+    /// @brief Retrieves options modified after specified time.
     ///
     /// @param selector Server selector.
     /// @param modification_time Lower bound option modification time.
@@ -171,6 +171,10 @@ public:
     getGlobalParameter4(const db::ServerSelector& selector,
                         const std::string& name) const = 0;
 
+    /// @brief Retrieves all global parameters modified after specified time.
+    ///
+    /// @param selector Server selector.
+    /// @param modification_time Lower bound parameter modification time.
     /// @return Collection of global parameters.
     virtual data::StampedValueCollection
     getAllGlobalParameters4(const db::ServerSelector& selector) const = 0;

diff --git a/src/lib/dhcpsrv/config_backend_dhcp4_mgr.cc b/src/lib/dhcpsrv/config_backend_dhcp4_mgr.cc
index 134f0200c4613986b930982f35a3f02fed564707..587cbc8e8ffeb2729ef4dfa75fa28899923233f4 100644 (file)
--- a/src/lib/dhcpsrv/config_backend_dhcp4_mgr.cc
+++ b/src/lib/dhcpsrv/config_backend_dhcp4_mgr.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -25,7 +25,7 @@ ConfigBackendDHCPv4Mgr::create() {
 
 void
 ConfigBackendDHCPv4Mgr::destroy() {
-    getConfigBackendDHCPv4MgrPtr().reset(new ConfigBackendDHCPv4Mgr());
+    getConfigBackendDHCPv4MgrPtr().reset();
 }
 
 ConfigBackendDHCPv4Mgr&

diff --git a/src/lib/dhcpsrv/config_backend_dhcp6.h b/src/lib/dhcpsrv/config_backend_dhcp6.h
index f667fd2186be8ca5d423431b3a641209618aeb12..3bba27646b070205e7d841d252356bea2c0de189 100644 (file)
--- a/src/lib/dhcpsrv/config_backend_dhcp6.h
+++ b/src/lib/dhcpsrv/config_backend_dhcp6.h
@@ -151,7 +151,7 @@ public:
     virtual OptionContainer
     getAllOptions6(const db::ServerSelector& server_selector) const = 0;
 
-    /// @brief Retrieves option modified after specified time.
+    /// @brief Retrieves options modified after specified time.
     ///
     /// @param selector Server selector.
     /// @param modification_time Lower bound option modification time.
@@ -171,6 +171,10 @@ public:
     getGlobalParameter6(const db::ServerSelector& selector,
                         const std::string& name) const = 0;
 
+    /// @brief Retrieves all global parameters modified after specified time.
+    ///
+    /// @param selector Server selector.
+    /// @param modification_time Lower bound parameter modification time.
     /// @return Collection of global parameters.
     virtual data::StampedValueCollection
     getAllGlobalParameters6(const db::ServerSelector& selector) const = 0;

diff --git a/src/lib/dhcpsrv/config_backend_dhcp6_mgr.cc b/src/lib/dhcpsrv/config_backend_dhcp6_mgr.cc
index 9d14e0ea8c35bd3156bd4404ec6a35542f25a9ce..9fc5231f8d940a45e343b14f1507b36e4bc7c0a2 100644 (file)
--- a/src/lib/dhcpsrv/config_backend_dhcp6_mgr.cc
+++ b/src/lib/dhcpsrv/config_backend_dhcp6_mgr.cc
@@ -25,7 +25,7 @@ ConfigBackendDHCPv6Mgr::create() {
 
 void
 ConfigBackendDHCPv6Mgr::destroy() {
-    getConfigBackendDHCPv6MgrPtr().reset(new ConfigBackendDHCPv6Mgr());
+    getConfigBackendDHCPv6MgrPtr().reset();
 }
 
 ConfigBackendDHCPv6Mgr&