]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
leds: core: Fix formatting issues
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 12 Mar 2026 01:43:28 +0000 (18:43 -0700)
committerLee Jones <lee@kernel.org>
Thu, 26 Mar 2026 09:31:58 +0000 (09:31 +0000)
Fix formatting issues reported by checkpatch.pl, such as extra empty
lines, lack of braces on some branches, and misaligned function
arguments.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://patch.msgid.link/20260311-led-swnode-name-v1-2-798a49e041c6@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/led-core.c

index 8ce41b36c64556b3ff7549c1f5d02d3d84b9342c..385e78af1daced6a8795f8c515452cb9b72aaf5b 100644 (file)
@@ -85,7 +85,7 @@ static void led_timer_function(struct timer_list *t)
        if (!brightness) {
                /* Time to switch the LED on. */
                if (test_and_clear_bit(LED_BLINK_BRIGHTNESS_CHANGE,
-                                       &led_cdev->work_flags))
+                                      &led_cdev->work_flags))
                        brightness = led_cdev->new_blink_brightness;
                else
                        brightness = led_cdev->blink_brightness;
@@ -217,10 +217,9 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
        mod_timer(&led_cdev->blink_timer, jiffies + 1);
 }
 
-
 static void led_blink_setup(struct led_classdev *led_cdev,
-                    unsigned long *delay_on,
-                    unsigned long *delay_off)
+                           unsigned long *delay_on,
+                           unsigned long *delay_off)
 {
        if (!test_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags) &&
            led_cdev->blink_set &&
@@ -262,7 +261,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev,
                           int invert)
 {
        if (test_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags) &&
-            timer_pending(&led_cdev->blink_timer))
+           timer_pending(&led_cdev->blink_timer))
                return;
 
        set_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags);
@@ -347,9 +346,9 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev, unsigned int value)
        /* Ensure delayed_set_value is seen before work_flags modification */
        smp_mb__before_atomic();
 
-       if (value)
+       if (value) {
                set_bit(LED_SET_BRIGHTNESS, &led_cdev->work_flags);
-       else {
+       else {
                clear_bit(LED_SET_BRIGHTNESS, &led_cdev->work_flags);
                clear_bit(LED_SET_BLINK, &led_cdev->work_flags);
                set_bit(LED_SET_BRIGHTNESS_OFF, &led_cdev->work_flags);
@@ -499,7 +498,6 @@ static void led_parse_fwnode_props(struct device *dev,
                        props->color_present = true;
        }
 
-
        if (!fwnode_property_present(fwnode, "function"))
                return;
 
@@ -584,8 +582,9 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,
        } else if (is_software_node(fwnode)) {
                n = snprintf(led_classdev_name, LED_MAX_NAME_SIZE, "%s",
                             fwnode_get_name(fwnode));
-       } else
+       } else {
                return -EINVAL;
+       }
 
        if (n >= LED_MAX_NAME_SIZE)
                return -E2BIG;