]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
don't deref NULL. Found by Klockwork (www.klocwork.com)
authorMichael Jerris <mike@jerris.com>
Wed, 21 May 2008 22:40:04 +0000 (22:40 +0000)
committerMichael Jerris <mike@jerris.com>
Wed, 21 May 2008 22:40:04 +0000 (22:40 +0000)
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@8515 d0543943-73ff-0310-b7d9-9358b9ac24b2

src/mod/formats/mod_sndfile/mod_sndfile.c

index 18719b0009c8c8c121c9822d5ff9e80d8c6ec693..1331b14cc01ebe16a53513cd0dd0684f73d7cbea 100644 (file)
@@ -323,18 +323,22 @@ static switch_status_t setup_formats(void)
                        char *p;
                        struct format_map *map = switch_core_permanent_alloc(sizeof(*map));
                        switch_assert(map);
-
+       
                        map->ext = switch_core_permanent_strdup(info.extension);
                        map->uext = switch_core_permanent_strdup(info.extension);
                        map->format = info.format;
-                       for (p = map->ext; *p; p++) {
-                               *p = (char) tolower(*p);
+                       if (map->ext) {
+                               for (p = map->ext; *p; p++) {
+                                       *p = (char) tolower(*p);
+                               }
+                               switch_core_hash_insert(globals.format_hash, map->ext, map);
                        }
-                       for (p = map->uext; *p; p++) {
-                               *p = (char) toupper(*p);
+                       if (map->uext) {
+                               for (p = map->uext; *p; p++) {
+                                       *p = (char) toupper(*p);
+                               }
+                               switch_core_hash_insert(globals.format_hash, map->uext, map);
                        }
-                       switch_core_hash_insert(globals.format_hash, map->ext, map);
-                       switch_core_hash_insert(globals.format_hash, map->uext, map);
                        supported_formats[len++] = (char *) info.extension;
                }
                format = info.format;