Fix for resource leak on error path.

Make sure opened file descriptors are cleaned up
in the exit path when error occured.

Signed-off-by: Artur Wojcik <artur.wojcik@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

diff --git a/probe_roms.c b/probe_roms.c
index a9a86388f394233fd36796e7713ea43ce8d71a2f..0f0ffbccbdc8c1bb14ce158042c61d7ce658743f 100644 (file)
--- a/probe_roms.c
+++ b/probe_roms.c
@@ -80,7 +80,7 @@ void probe_roms_exit(void)
 
 int probe_roms_init(unsigned long align)
 {
-       int fd;
+       int fd = -1;
        int rc = 0;
 
        /* valid values are 2048 and 512.  512 is for PCI-3.0 compliant
@@ -107,9 +107,11 @@ int probe_roms_init(unsigned long align)
 
        if (rc == 0)
                rom_fd = fd;
-       else
+       else {
+               if (fd >= 0) 
+                       close(fd);
                probe_roms_exit();
-
+       }
        return rc;
 }