Shutdown all active TCP connections on error

When outgoing TCP connection was prematurely terminated (f.e. with
connection reset), the dispatch code would not cleanup the resources
used by such connection leading to dangling dns_dispentry_t entries.

diff --git a/lib/dns/dispatch.c b/lib/dns/dispatch.c
index e52d7970a7e9364a2b498a46d3b755b52e060732..0893c39894a6a663b30b25fec7325b216ef31876 100644 (file)
--- a/lib/dns/dispatch.c
+++ b/lib/dns/dispatch.c
@@ -688,6 +688,16 @@ tcp_recv(isc_nmhandle_t *handle, isc_result_t eresult, isc_region_t *region,
                             "shutting down due to TCP "
                             "receive error: %s: %s",
                             buf, isc_result_totext(eresult));
+               /*
+                * If there are any active responses, shut them all down.
+                */
+               for (resp = ISC_LIST_HEAD(disp->active); resp != NULL;
+                    resp = next) {
+                       next = ISC_LIST_NEXT(resp, alink);
+                       dispentry_attach(resp, &(dns_dispentry_t *){ NULL });
+                       ISC_LIST_UNLINK(disp->active, resp, alink);
+                       ISC_LIST_APPEND(resps, resp, rlink);
+               }
                goto done;
        }