]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Author: Philippe Lantin <plantin@cobaltgroup.com>
authorAmos Jeffries <squid3@treenet.co.nz>
Thu, 24 Sep 2009 09:24:45 +0000 (21:24 +1200)
committerAmos Jeffries <squid3@treenet.co.nz>
Thu, 24 Sep 2009 09:24:45 +0000 (21:24 +1200)
Bug 2624: Invalid response for IMS request

Squid forgot to verify the client provided If-Modified-Since when
seeing a 304 from upstream.

src/client_side_reply.cc

index 541abc7ed206df227edbbc476fcda8002220e364..f10ee157575b4f875d8cdab952b7ca0498e3c38a 100644 (file)
@@ -366,7 +366,7 @@ clientReplyContext::handleIMSReply(StoreIOBuffer result)
 
        // if client sent IMS
 
-       if (http->request->flags.ims) {
+        if (http->request->flags.ims && !old_entry->modifiedSince(http->request)) {
            // forward the 304 from origin
            debugs(88, 3, "handleIMSReply: origin replied 304, revalidating existing entry and forwarding 304 to client");
            sendClientUpstreamResponse();