Fix NULL-dereference added in rev.12611

* strto*() may be called without a value parameter when used simply to
  verify the content of a string is a valid conversion.

  Detected by Coverity Scan. Issue 970939.

diff --git a/compat/xstrto.cc b/compat/xstrto.cc
index 7dd72a8e3d4623f097fe922cd255c6c629b45ef9..1fffd5412ad7e6c908ebbcab4e77380fbcb6dfec 100644 (file)
--- a/compat/xstrto.cc
+++ b/compat/xstrto.cc
@@ -85,11 +85,12 @@ xstrtoui(const char *s, char **end, unsigned int *value,
     bool ret;
 
     ret = xstrtoul(s, end, &v, min, max);
-    if (value != NULL)
+    if (value != NULL) {
         *value = v;
 
-    if (v != static_cast<unsigned long>(*value)) {
-        return false;
+        if (v != static_cast<unsigned long>(*value)) {
+            return false;
+        }
     }
 
     return ret;