]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sched/fair: Update overutilized detection
authorVincent Guittot <vincent.guittot@linaro.org>
Fri, 13 Feb 2026 10:17:51 +0000 (11:17 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 23 Feb 2026 17:04:11 +0000 (18:04 +0100)
Checking uclamp_min is useless and counterproductive for overutilized state
as misfit can now happen without being in overutilized state.

Since commit e5ed0550c04c ("sched/fair: unlink misfit task from cpu overutilized")
util_fits_cpu returns -1 when uclamp_min is above capacity which is not
considered as cpu overutilized.

Remove the useless rq_util_min parameter.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Qais Yousef <qyousef@layalina.io>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/20260213101751.3121899-1-vincent.guittot@linaro.org
kernel/sched/fair.c

index 23315c294da1589c7ddfa9a3c5b93cadcc08ebc8..b8b052b2149b703afe74fae395bd22f8c499fe79 100644 (file)
@@ -7018,16 +7018,15 @@ static inline void hrtick_update(struct rq *rq)
 
 static inline bool cpu_overutilized(int cpu)
 {
-       unsigned long  rq_util_min, rq_util_max;
+       unsigned long rq_util_max;
 
        if (!sched_energy_enabled())
                return false;
 
-       rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN);
        rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX);
 
        /* Return true only if the utilization doesn't fit CPU's capacity */
-       return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu);
+       return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu);
 }
 
 /*