dns_db_setloop called at wrong place on wrong db

In cache_create_db, dns_db_setloop should be called on the newly
created db only if the database creation succeeded.

diff --git a/lib/dns/cache.c b/lib/dns/cache.c
index d425316cc463ae4c892706a6f55cd4220f67494d..902ae732e995d8e68d3e98aa6324a9e1b61e6c18 100644 (file)
--- a/lib/dns/cache.c
+++ b/lib/dns/cache.c
@@ -101,10 +101,9 @@ cache_create_db(dns_cache_t *cache, dns_db_t **db) {
        if (result == ISC_R_SUCCESS) {
                dns_db_setservestalettl(*db, cache->serve_stale_ttl);
                dns_db_setservestalerefresh(*db, cache->serve_stale_refresh);
+               dns_db_setloop(*db, cache->loop);
        }
 
-       dns_db_setloop(cache->db, cache->loop);
-
        return (result);
 }