]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-38449: Add URL delimiters test cases (GH-16729)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sun, 1 Dec 2019 23:23:32 +0000 (15:23 -0800)
committerGitHub <noreply@github.com>
Sun, 1 Dec 2019 23:23:32 +0000 (15:23 -0800)
* bpo-38449: Add tricky test cases

* bpo-38449: Reflect codereview
(cherry picked from commit 2fe4c48917c2d1b40cf063c6ed22ae2e71f4cb62)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Lib/test/test_mimetypes.py

index adbec8dab4266ea8002dc7f282c937de06a73571..f29de8c3a1a28327b4c2bcfdcae3e25f1fe9c51d 100644 (file)
@@ -50,6 +50,21 @@ class MimeTypesTestCase(unittest.TestCase):
         eq(self.db.guess_type('foo.xul', strict=False), ('text/xul', None))
         eq(self.db.guess_extension('image/jpg', strict=False), '.jpg')
 
+    def test_filename_with_url_delimiters(self):
+        # bpo-38449: URL delimiters cases should be handled also.
+        # They would have different mime types if interpreted as URL as
+        # compared to when interpreted as filename because of the semicolon.
+        eq = self.assertEqual
+        gzip_expected = ('application/x-tar', 'gzip')
+        eq(self.db.guess_type(";1.tar.gz"), gzip_expected)
+        eq(self.db.guess_type("?1.tar.gz"), gzip_expected)
+        eq(self.db.guess_type("#1.tar.gz"), gzip_expected)
+        eq(self.db.guess_type("#1#.tar.gz"), gzip_expected)
+        eq(self.db.guess_type(";1#.tar.gz"), gzip_expected)
+        eq(self.db.guess_type(";&1=123;?.tar.gz"), gzip_expected)
+        eq(self.db.guess_type("?k1=v1&k2=v2.tar.gz"), gzip_expected)
+        eq(self.db.guess_type(r" \"\`;b&b&c |.tar.gz"), gzip_expected)
+
     def test_guess_all_types(self):
         eq = self.assertEqual
         unless = self.assertTrue