]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pwm: fsl-ftm: Handle clk_get_rate() returning 0
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Tue, 1 Apr 2025 10:29:01 +0000 (12:29 +0200)
committerUwe Kleine-König <ukleinek@kernel.org>
Fri, 4 Apr 2025 07:23:56 +0000 (09:23 +0200)
Considering that the driver doesn't enable the used clocks (and also
that clk_get_rate() returns 0 if CONFIG_HAVE_CLK is unset) better check
the return value of clk_get_rate() for being non-zero before dividing by
it.

Fixes: 3479bbd1e1f8 ("pwm: fsl-ftm: More relaxed permissions for updating period")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/b68351a51017035651bc62ad3146afcb706874f0.1743501688.git.u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-fsl-ftm.c

index 2510c10ca47303d789feb760756da6c5fee45ec8..c45a5fca4cbbd296e49fcf13c46920423063a11a 100644 (file)
@@ -118,6 +118,9 @@ static unsigned int fsl_pwm_ticks_to_ns(struct fsl_pwm_chip *fpc,
        unsigned long long exval;
 
        rate = clk_get_rate(fpc->clk[fpc->period.clk_select]);
+       if (rate >> fpc->period.clk_ps == 0)
+               return 0;
+
        exval = ticks;
        exval *= 1000000000UL;
        do_div(exval, rate >> fpc->period.clk_ps);
@@ -190,6 +193,9 @@ static unsigned int fsl_pwm_calculate_duty(struct fsl_pwm_chip *fpc,
        unsigned int period = fpc->period.mod_period + 1;
        unsigned int period_ns = fsl_pwm_ticks_to_ns(fpc, period);
 
+       if (!period_ns)
+               return 0;
+
        duty = (unsigned long long)duty_ns * period;
        do_div(duty, period_ns);